search

tud-phi / ros2-elastica

ROS2 package implementing Elastica
0 stars 0 forks source link

Integrate into our Dockerfile #5

Closed mstoelzle closed 2 years ago

mstoelzle commented 2 years ago

Please integrate the simulator into our Dockerfile: https://github.com/tud-cor-sr/sr-ros2-bundles

The repo can be added to the overlay.repo file so that it is automatically downloaded. You can develop in your own branch and then create a PR at the end.

Important: The elastica dependencies and the repo should only be included in the Docker image, if an argument is set to true in docker-compose. E.g. we should also be able to build docker images easily without the Elastica simulator

RUFFY-369 commented 2 years ago

Hi @mstoelzle , I'll look into it.

RUFFY-369 commented 2 years ago

HI @mstoelzle , I have pushed the required commits to https://github.com/tud-cor-sr/sr-ros2-bundles

RUFFY-369 commented 2 years ago

Hi @mstoelzle , Should we close this issue now?

mstoelzle commented 2 years ago

Please update the README to reflect that we are now referring to our sr-ros2-bundles repo instead of our prebuilt Docker image

RUFFY-369 commented 2 years ago

Hi @mstoelzle , I have updated the readme in the recent push. Please check it.