search

tud-phi / ros2-elastica

ROS2 package implementing Elastica
0 stars 0 forks source link

Rework naming of files and classes #8

Closed mstoelzle closed 2 years ago

mstoelzle commented 2 years ago

To me the naming of some of the files and classes does not make sense yet. Could you please revise this?

One example would be the filename of ros2_elastica_torque_force_params.py and the class name of MinimalPublisherSubscriberForces. The names should be easily understandable and follow some patterns and conventions

RUFFY-369 commented 2 years ago

Hi @mstoelzle , Yeah the naming convention was something I needed to discuss. So, as of now I have used the same pattern as of the package name for those scripts. Kindly comment on the current names of those files & classes.

mstoelzle commented 2 years ago

It looks good for now. Maybe later, we will need to do some further adjustments