search

tud-zih-energy / FIRESTARTER

FIRESTARTER: A Processor Stress Test Utility. This repository contains the source code generator. Our releases (including the generated source code and precompiled binaries) are available at https://tu-dresden.de/zih/firestarter/.
GNU General Public License v3.0
116 stars 25 forks source link

Caliper #54

Closed tjeter closed 4 months ago

tjeter commented 4 months ago

I have added Caliper annotations to Firestarter in various regions. Some annotations have commented out because they do not yield significant results reported in the call tree of a Caliper file.

rschoene commented 4 months ago

This will not be merged for two main reasons. Please read to the end if you want to include Caliper in the future.

Reason 1: Clean code:

There are multiple lines which are just commented out. This should not be the case.

Reason 2: We already have too many dependencies

I would rather not add another dependency to the main code but have an optional dependency where you can link things to FS, if you want to. We already have VT and Score-P instrumentation, which could have been used as a hook to match against Caliper. I also worry about the possible testing of the frameworks.

How to proceed and get Caliper into FS?

Please have a look at this new issue #55 . I think the code would be cleaner if there were not too many includes and ifdefs spread over all of the code but have it separated away. Maybe you could help with that?

Once this is done, you can add a new pull request

Best regards

rschoene commented 2 months ago

Please have a look at: https://github.com/tud-zih-energy/FIRESTARTER/tree/unifytracing for a first draft.

rschoene commented 2 months ago

@tjeter any comments or suggestions?

tjeter commented 1 month ago

@rschoene I am taking a look at this. I will try to have a PR soon.

rschoene commented 1 month ago

@tjeter great to hear. please have a look at the updates :) It should make things easier...