tud-zih-energy / lo2s

Linux OTF2 Sampling - A Lightweight Node-Level Performance Monitoring Tool
https://tu-dresden.de/zih/forschung/projekte/lo2s?set_language=en
GNU General Public License v3.0
45 stars 13 forks source link

build: Link with libsframe and libzstd #249

Closed bmario closed 1 year ago

bmario commented 1 year ago

Newer binutils (>=2.40) want to be linked against libsframe and libzstd. To still support older binutils, we guess with this heuristic: If we find a libsframe, we require a suitable libzstd.

cvonelm commented 1 year ago

Building this under Arch Linux with the default options fails due to a missing static libzstd.

However, the build using lo2s_USE_STATIC_LIBS=OFF works flawlessly.

As already discussed, it is very unlikely that Arch Linux will start shipping a static libzstd due to this bug and their generally static unfriendly policy.

bmario commented 1 year ago

We talked about that and came to the conclusion that we want to change the default setting of lo2s_USE_STATIC_LIBS from MOSTLY to OFF. However, that should be a different PR.

I think this is good to go then.