search

tud-zih-energy / lo2s

Linux OTF2 Sampling - A Lightweight Node-Level Performance Monitoring Tool
https://tu-dresden.de/zih/forschung/projekte/lo2s?set_language=en
GNU General Public License v3.0
45 stars 13 forks source link

fix(EventDescription): Turn EventDescription into real class #276

Closed cvonelm closed 11 months ago

cvonelm commented 1 year ago

The current EventDescription is a mere struct with exposed struct members etc. This PR attempts to rework the EventDescription into a proper class while integrating some of the Event Handling Code into this new class.

This fixes #224

This also fixes #275, a bug that prevents events from showing if they could only be opened with exclude_kernel=1

bmario commented 1 year ago

I'm out of the loop about this. Can you extend the PR description (and commit message) and elaborate on what this PR tries to achieve?

cvonelm commented 1 year ago

I will be updating the commit message once this is ready for merging and squashed.

cvonelm commented 11 months ago

Dropping this PR in favour of a more thorough refactoring based on the raii-fd branch.