tud-zih-energy / lo2s

Linux OTF2 Sampling - A Lightweight Node-Level Performance Monitoring Tool
https://tu-dresden.de/zih/forschung/projekte/lo2s?set_language=en
GNU General Public License v3.0
45 stars 13 forks source link

Switch otf2 metric mode from accumulated_start to accumulated_last #279

Open cvonelm opened 1 year ago

cvonelm commented 1 year ago

Currently, we are using accumulated_start for perf metrics. In this mode, the metric value we write is the sum of all metric readouts since the beginning of measurements.

Alternatively, afaik, we could use accumulated_last, where we write the individual metric readouts instead.

This is not the highest priority of issue but to my knowledge it seems that the accumulation we are doing in lo2s is unnecessary.

And additionally, with accumulation we always run the risk that issues such as #267 mess up the accumulation variable by adding values such as NaN or infinity.

tilsche commented 1 year ago

IIRC this was done primarily because of long-standing bug(s) in Vampir. We have to carefully check if those are properly fixed.