Closed Tooa closed 8 years ago
@alexanderpanchenko Can you have a look at this?
Ok. I do the rebase myself. Please write in future one comment or edit your messages.
these were comments related to code (check above) + one normal comment :-)
Oh, sry :v: Regarding your workflow question: I suggest to work on single feature branches (maybe prefix with feature or fix) and rebase the code. The pull request should also be just one commit (squash commits) and the fast forward merge should be without an additional merge commit (no --no-ff
).
Once I have time, I will summarize the detailed workflow in CONTRIBUTING.md
for git beginners.
Sound very reasonable. Since I am most likely will not contribute that much to the codebase (i just do not have time due to other projects), you just need to agree on the rules with other developers like Seid in case of conflicts.
This pull request adds the initial project structure. The pull also adds several features:
LazyLogging
)scopt