search

tudat-team / tudat-space

An introduction and guide to tudat-space.
https://tudat-space.readthedocs.io
14 stars 17 forks source link

Initial test commit with slight changes #63

Closed sbcowan closed 2 years ago

sbcowan commented 2 years ago

Hello to whoever accepts/rejects pull requests,

I will be contributing to the pygmo_examples/pygmo_orbit_optimization part of the tudat-space docs as part of my TA work for Propagation and Optimization. I was instructed by Dominic to first push to a separate branch so as not to directly mess with the tudat-space documentation as it is now. I am new to issuing pull requests; does this pull request add a new branch—the local branch I created and pushed from—to the tudat-space repository?

Thanks, Sean

sbcowan commented 2 years ago

After posting this draft pull request, It states that I want to merge a commit into tudat-team:master. This makes me think that, if accepted, the pull request would immediately merge into the master branch? In that case, how do I open a pull request to commit to a branch that doesn't exist on the tudat-team/tudat-space repository ?

DominicDirkx commented 2 years ago

After posting this draft pull request, It states that I want to merge a commit into tudat-team:master. This makes me think that, if accepted, the pull request would immediately merge into the master branch?

That's right

In that case, how do I open a pull request to commit to a branch that doesn't exist on the tudat-team/tudat-space repository ?

When creating a pull request, there is an option (dropdown menu at the top left-ish), where you can select the target branch.

sbcowan commented 2 years ago

@DominicDirkx I can only select existing branches on the tudat-team repository for the target branch. When I try to create a branch upstream (being tudat-team/tudat-space) from the terminal, I get the following:

_17:41:08 0 AsteroidExampleDocs/tudat-space % git checkout -b feature/asteroidimaging_example upstream/feature/asteroidimaging_example feature/asteroidimaging_example fatal: 'upstream/feature/asteroidimaging_example' is not a commit and a branch 'feature/asteroidimagingexample' cannot be created from it

What may have gone wrong there is that I originally used git push origin feature/asteroidimaging_example, where origin is my local repository. Though as a solution, when trying _git push -u upstream feature/asteroidimagingexample, the full error output is:

remote: Permission to tudat-team/tudat-space.git denied to sbcowan. fatal: unable to access 'https://github.com/tudat-team/tudat-space.git/': The requested URL returned error: 403

Thus, I believe I need some level of access to push to a new branch on the tudat-team/tudat-space repository?