Closed gregoriomarchesini closed 2 years ago
Hi Greg, this looks useful :) Thanks!
@Marchesini010126 If we were to add this now, we would copy paste this into he code and push it. If you formulate it as a pull request, your name would also show up in the tudat git commit history. In case you would want that, for us it makes little difference (I think)
@gaffarelj Could you add these to a future tudatpy update?
Hi all :)
I can take care of adding these functions to tudatpy, yes. Looking through them, I will then put them inside the tudatpy.util module.
@Marchesini010126 tell me if you want to take care of it trough a push request, otherwise I will make it myself, and mention your username in the commit message.
Hi
You can definitely go ahead. It is fine for me even if I don’t make the push my self Happy to help you !
Gregorio Marchesini
Personal Email @.***
Academic Email @.***
On 5 Apr 2022, at 14:22, Jérémie Gaffarel @.***> wrote:
Hi all :)
I can take care of adding these functions to tudatpy, yes. Looking through them, I will then put them inside the tudatpy.util module.
@Marchesini010126 https://github.com/Marchesini010126 tell me if you want to take care of it trough a push request, otherwise I will make it myself, and mention your username in the commit message.
— Reply to this email directly, view it on GitHub https://github.com/tudat-team/tudat-space/issues/65#issuecomment-1088637261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ76ADGGG6WW3PG5BYCZMTTVDQV7DANCNFSM5SSF5JRA. You are receiving this because you were mentioned.
Hi @Marchesini010126!
Small update: I think that there is an incorrect assumption with your split_history
function. It looks like you assume your state to be [translational body A, mass body A, translational body B, mass body B], where it is in fact [translational body A, translational body B, mass body A, mass body B] (as an example).
So your function, as it is, would work fine if you propagate only translational dynamics, but not if you propagate any other state type (like mass, rotational, etc).
I am making the appropriate changes to your function (and tudatpy) so that this functionality can still be implemented, but that will take just a little bit longer (though it's well underway already).
Hey
Yes you are right I mainly work with translational dynamics and this is the reason why I had made this assumption.
Really grateful I watched this issue and let me know if you need anything! Great catch
Have a nice day Gregorio Marchesini
Personal Email @.***
Academic Email @.***
On 8 Apr 2022, at 16:43, Jérémie Gaffarel @.***> wrote:
Hi @Marchesini010126 https://github.com/Marchesini010126!
Small update: I think that there is an incorrect assumption with your split_history function. It looks like you assume your state to be [translational body A, mass body A, translational body B, mass body B], where it is in fact [translational body A, translational body B, mass body A, mass body B] (as an example). So your function, as it is, would work fine if you propagate only translational dynamics, but not if you propagate any other state type (like mass, rotational, etc).
I am making the appropriate changes to your function (and tudatpy) so that this functionality can still be implemented, but that will take just a little bit longer (though it's well underway already).
— Reply to this email directly, view it on GitHub https://github.com/tudat-team/tudat-space/issues/65#issuecomment-1092937238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ76ADF4TOT76JKJHVZBJFDVEBA25ANCNFSM5SSF5JRA. You are receiving this because you were mentioned.
I implemented both of these functions and made this pull request accordingly. @DominicDirkx can you review it?
Thanks again for these additions @Marchesini010126 :)
These new features have been merged with tudatpy/develop
with commit c56ab7f.
They will be included in the next conda release of tudatpy, and in the online documentation as soon as possible (there is a little fix needed for the docs to be updatable again).
Just to confirm, the new API docs (that are now building again) contain the two new features mentioned in this issue:
Hi
I have written two simple functions that could be useful in the future if you want to add them. I hope they can be of any help and let me know if you want me to modify them