tudat-team / tudat

A C++ platform to perform astrodynamics and space research.
BSD 3-Clause "New" or "Revised" License
17 stars 28 forks source link

Final iteration residuals in estimateParameters #176

Closed MiguelAvillez closed 1 year ago

MiguelAvillez commented 1 year ago

For the final iteration of estimateParameters(), the parameters are updated but the residuals resulting from that update are never computed. This also leads to an inconsistent number of values in the parameter history and the residual history (the former has one extra element). Correct this :)

DominicDirkx commented 1 year ago

Required modifications have been made here: https://github.com/tudat-team/tudat/pull/183

The 'parameter estimate' that is provided as output is not always one for which the residuals have been calculated, and not one that is computed with the correction based on the last residuals. There is an option (default true) to add this final correction (for which the quality is not directly evaluated) to the EstimationOutput. Documentation will follow with associated tudatpy pull request.