tudat-team / tudat

A C++ platform to perform astrodynamics and space research.
BSD 3-Clause "New" or "Revised" License
17 stars 27 forks source link

Automatically add empty tabulated ephemeris when needed #20

Closed DominicDirkx closed 2 years ago

DominicDirkx commented 2 years ago

When setting the results of a numerical propagation using the Simulator (https://tudatpy.readthedocs.io/en/latest/numerical_simulation.html#tudatpy.numerical_simulation.SingleArcSimulator, set_integrated_result = true), the propagated body needs to have a compatible ephemeris. If it does not, it crashes at present (with an error?), This can be made more robust by adding an ephemeris 'on the fly'

DominicDirkx commented 2 years ago

Some progress has been made:

https://github.com/tudat-team/tudat/tree/feature/automatic_tabulated_ephemeris

The modifications have been checked with selected unit tests. Modification will not work (yet) for multi- and hybrid-arc

DominicDirkx commented 2 years ago

All unit tests are now passing, but the automatic creation of a tabulated ephemeris (either translational or rotational) is only working for single arc. When using a multi-arc propagation, and wanting to reset the ephemeris, a user still needs to manually define a multi-arc ephemeris in the body that is to be propagated.

Update: considering the fact that @MarieFayolle will be adding some significant additions to the multi-arc propagation, which may influence the solution to this issue, I propose that the above code gets merged now, and the multi- and hybrid-arc auto-ephemeris creation gets added after her work is added.

SamFayolle commented 2 years ago

Hi Dominic, I gave it a look and I completely agree with you that it is better to push the single arc code now and wait for the coming modifications of the multi arc propagation. Especially, one think on my todo list for next week is to modify how to reset ephemerides in the multi-arc case, so I guess it makes perfect sense to wait for those changes.

DominicDirkx commented 2 years ago

Code has been merged :)