search

tudelft3d / 3d-building-metrics

Tool to compute shape metrics from 3D geometries for buildings
MIT License
37 stars 9 forks source link

Collaboration with PySAL / momepy #12

Open martinfleis opened 2 years ago

martinfleis commented 2 years ago

Hi, congratulations on a great paper!

Sorry for hijacking your issue tracker but I have a small proposal here. As you probably know, I am the author of momepy, a Python package for urban morphometrics that now lives under PySAL umbrella. I could help myself to propose a collaboration here.

Momepy includes a wide range of characters, including those to measure shape, mostly for 2D, but some work with height as well. What you have in your shape_index.py is exactly that sort of functions momepy offers but not all you have here are available in momepy. Would you be willing to contribute them?

I believe that there is a massive benefit in collecting all these tools at one place, rather than having individual repositories attached to individual papers. I'd be more than happy to help incorporating your additions to the code base of momepy.

Let me know what you think and feel free to say no if you prefer to keep your code only here or elsewhere.

Thanks!

Martin

liberostelios commented 2 years ago

Hi @martinfleis,

Thank you very much for the nice words! 😊

We would be thrilled to contribute to momepy! I completely agree, that it's much better if things are all in one place than people having to use different repositories for things. And what better way to do this than momepy, which is already very popular!

I am not sure what is the best way to proceed. One way to do this is that you can, maybe, raise issues in the momepy repository (one for every index you'd like to have incorporated) and then we can make pull requests to implement them there. Would that work for you? Any better suggestions?

Athelena commented 2 years ago

Hi @martinfleis!

Thank you so much! As Stelios said we'd be thrilled. Especially since momepy was such a big inspiration for us and a tool we use often.

Just let us know how you'd like to proceed and we're happy to help 😄

Cheers, Anna

martinfleis commented 2 years ago

That is great to hear! I will open an issue in momepy and tag you there ;).