search

tudelft3d / 3d-building-metrics

Tool to compute shape metrics from 3D geometries for buildings
MIT License
36 stars 8 forks source link

Refactor into a library and contributing #16

Open balazsdukai opened 10 months ago

balazsdukai commented 10 months ago

Hello, we use your code for computing the shared walls in the 3DBAG and have a fork of your repo at https://github.com/3DGI/urban-morphology-3d . However, our fork has diverged significantly, mostly for two reasons:

  1. we need to use the 3d-building-metrics as a library, so we've refactored the package accordingly,
  2. we've some 3DBAG-specific code in the cityStats module.

I would be happy to move our 3DBAG specific changes to a separate package and open a PR (or multiple PR's) with our changes for making the 3d-building-metrics usable as a library. Are you open to this?

lukasbeuster commented 10 months ago

Hey, just chiming in on the sidelines, I'd definitely be interested in the refactored version of this so pretty please 👍

StylianosVitalis-TomTom commented 10 months ago

Hey @balazsdukai,

More than happy to have this PR. For what is worth, we are still working on the integration of most of the functionality in momepy, but I suppose this will only be about the indexes. So the part about shared walls calculation or comparing volumes won't make it to there. So, any PR to expose this in a more easy way would be very welcome. 👍