search

tudelft3d / 3dfier

The open-source tool for creating 3D models
http://tudelft3d.github.io/3dfier
GNU General Public License v3.0
526 stars 106 forks source link

Version 1.3 doesn't run my "old version 1.2.2" YAML file #121

Closed ghost closed 3 years ago

ghost commented 3 years ago

I am trying to run a YAML file that gave output with the 3dfier 1.2.2 version.

At the moment 3dfier 1.3 found the file valid but doesn't run, so no output... Find the yml file attached

ISSUE_3dfier_v13.zip

hugoledoux commented 3 years ago

I improved the handling of paths and added relative paths, and thought this was tested.

What is the error you get?

ghost commented 3 years ago

Actually... no errors It just doesn't do anything: it's reading the yml file, reporting the locations of the geopackages and then quits...

image

hugoledoux commented 3 years ago

I tried to replicate your error under Windows but I cannot. Are you 100% sure that there's a file at that location? And what are those gray rectangles?

Maybe you can try to see if you can run the testarea_config.yml in /example_data?

ghost commented 3 years ago

Well, the testdata works... So, very weird that my 'old' data seems to go wrong in the new version of 3dfier. Rewriting the yml didn't give any solutions Also all data is still in the same directories.

I'll give it a try to start from scratch with building the data and the yml file.

hugoledoux commented 3 years ago

I know why: you used wildcards (*) and my update of the paths didn't consider them.

I have a fix in branch "glob": could you try it with different yaml files configurations please? Once working I'll merge to master.

ghost commented 3 years ago

Yes, I will Thanks Hugo. As soons as I have results, I'll let you know

ghost commented 3 years ago

@hugoledoux : how do I implement the fix ? I don't have experience with that :-)

ghost commented 3 years ago

@hugoledoux : how do I implement the fix ? I don't have experience with that :-)

ghost commented 3 years ago

@hugoledoux : not closed for now, actually... Can you still help me with implementing the fix? Do I need to build a file?

hugoledoux commented 3 years ago

hmmm, okay I had assumed that since Future Insight's www.nederlandin3d.nl is built with 3dfier that you guys could compile C++ code.

So what you need to do is build the binary/exe from the source code, it's explained in the doc for Windows: https://tudelft3d.github.io/3dfier/installation.html#windows

You need to build for the branch mentioned above, not master

ghost commented 3 years ago

Ah, ok. No I'm sorry I'm not building the files.

So, ignoring this issue with the path, another issue pops up: buildings should be LoD0, but they are floeating above the surface and are extremely extruded.

For now, in my current project, I'm back to 1.2.2