tudelft3d / 3dfier

The open-source tool for creating 3D models
http://tudelft3d.github.io/3dfier
GNU General Public License v3.0
552 stars 108 forks source link

Does not compile on 10.11 with homebrew dependencies #21

Closed christianbraun closed 7 years ago

christianbraun commented 7 years ago

Dear all, I tried to compile 3dfier 0.82 without success. I did install dependencies with homebrew. What I get is:

$ cmake ..

-- The C compiler identification is AppleClang 8.0.0.8000042
-- The CXX compiler identification is AppleClang 8.0.0.8000042
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Boost version: 1.62.0
-- Found the following Boost libraries:
--   locale
--   chrono
--   system
--   filesystem
-- Found GDAL: /usr/local/Cellar/gdal2/2.1.2/lib/libgdal.dylib  
-- Searching for LibLAS + library
-- Searching for LASzip + library
-- Found YAMLCPP: /usr/local/include  
-- Build type: Release
-- USING CXXFLAGS = ' -DNDEBUG'
-- USING EXEFLAGS = ' '
-- Targetting Unix Makefiles
-- Using /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ compiler.
-- DARWIN_VERSION=15
-- Mac Leopard detected
-- Requested component: MPFR
-- Requested component: GMP
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/cbraun/src/3dfier-0.8.2/build
ERIN-CBA-02511:build cbraun$ make
Scanning dependencies of target 3dfier
[  7%] Building CXX object CMakeFiles/3dfier.dir/main.cpp.o
In file included from /Users/cbraun/src/3dfier-0.8.2/main.cpp:39:
/Users/cbraun/src/3dfier-0.8.2/Map3d.h:62:33: error: extra qualification on member
      'get_bounds'
  liblas::Bounds<double> Map3d::get_bounds();
                         ~~~~~~~^
1 error generated.
make[2]: *** [CMakeFiles/3dfier.dir/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/3dfier.dir/all] Error 2
make: *** [all] Error 2

Any ideas? Many thanks in advance Christian

tcommandeur commented 7 years ago

Hello Christian,

Thank you for your message, I found the issue in the Map3d.h file and the correct version is now available in the master branch. There was a faulty function declaration in the header; Original: liblas::Bounds<double> Map3d::get_bounds(); Correct: liblas::Bounds<double> get_bounds();

Tom