tudelft3d / City4CFD

Reconstruction of LoD2 3D city models for urban flow simulations
GNU Affero General Public License v3.0
95 stars 19 forks source link

Problem compiling on OpenSUSE Leap 15.3 #9

Closed BW-Sampath closed 1 year ago

BW-Sampath commented 1 year ago

I cannot compile the software on OpenSUSE Leap 15.3. CMake works fine without any errors, but the compilation fails. I tried compiling with 10 cores, FYI. I'm attaching both logs of CMake and make. log.make.txt log.cmake.txt

The errors seem to originate due to the lines https://github.com/tudelft3d/City4CFD/blob/99ace1360d26c0caf3a4aed1224734b18b75d4e1/src/Map3d.cpp#L337 https://github.com/tudelft3d/City4CFD/blob/99ace1360d26c0caf3a4aed1224734b18b75d4e1/src/PointCloud.cpp#L245

Replacing the two lines with

#pragma omp parallel

seems to give a successful compilation, but running the TUDcampus example case throws a segmentation fault error. Any help would be appreciated

ipadjen commented 1 year ago

Hi there. Thanks for including the logs.

It seems that the GCC compiler version 7 doesn't like the way things are handled with OpenMP. Using GCC 9 (should be available through package managers in Leap 15.3) would work.

Alternatively, you can compile without OpenMP by commenting out the line 41 in CMakeLists.txt

#find_package(OpenMP)

but then the code might run somewhat slower, depending on the size of your reconstruction. For the included example it won't make much of a difference.

BW-Sampath commented 1 year ago

Hi. Thanks for the quick response. Installing GCC 9 seems to have solved this compiling issue. Now I can run the example case without any problems

ipadjen commented 1 year ago

Great! Closing this then.