search

tudelft3d / ifcgref

MIT License
17 stars 1 forks source link

Using utility functions #2

Closed Moult closed 2 months ago

Moult commented 4 months ago

G'day! I had a peek through the code and notice a number of places which might benefit from util functions, and a number of places which might benefit from adding a util function upstream to IfcOpenShell :)

Have you seen https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.8.0/src/ifcopenshell-python/ifcopenshell/util/geolocation.py ? In particular there are quite a few goodies in the latest version.

Some you might enjoy:

These take into account the IFC2X3 fallback, as well as the new coordinate operations in IFC4X3. They also handle a few more situations that might be problematic (e.g. I saw a few instances of by_type("IfcGeometricRepresentationContext")[0] which might get a subcontext or non-Model/Plan context).

amiroo4 commented 3 months ago

Hi Dion,

Thanks for recommending the libraries. I'll take a look at them.