tudelft3d / pprepair

Validation and Automatic Repair of Planar Partitions
GNU General Public License v3.0
57 stars 22 forks source link

compilation fail #2

Closed spacedman closed 12 years ago

spacedman commented 12 years ago

Copying definitions.h to Definitions.h to fix previous issue, and then compiling gives:

$ make -f Makefile.linux c++ -Wall -O3 -frounding-math -fno-strict-aliasing -I/usr/include/gdal -L/usr/lib -c PolygonHandle.cpp PolygonHandle.cpp: In member function ‘bool MultiPolygonHandle::hasHandle(PolygonHandle_)’: PolygonHandle.cpp:242: error: no matching function for call to ‘find(std::_Listiterator<PolygonHandle>, std::_Listiterator<PolygonHandle*>, PolygonHandle&)’ make: _\ [PolygonHandle.o] Error 1

My C++ skills don't help here, I have no idea...

Ubuntu 10.04

All the other .o files in the Makefile compile okay, example:

$ make PlanarPartition.o g++ -c -o PlanarPartition.o PlanarPartition.cpp

spacedman commented 12 years ago

Fixed! To get this to compile for me, I needed to add #include to the stgart of PolygonHandle.cpp - perhaps my STL is older or something...

kenohori commented 12 years ago

Did you have to add #include ? Or was it something else? I was sure it was added in CGAL already, but I'll add it to make sure. It doesn't hurt. Thanks for the bug reports!

barryrowlingson commented 12 years ago

Yes, I had to #include <algorithm> (with angle-brackets - github thought I was putting an HTML tag in!)

kenohori commented 12 years ago

Aha. Yes, now I see that Github removed that part in my comment as well. I've added it to the definitions. Now it should compile without problems :-).