search

tudelft3d / pprepair

Validation and Automatic Repair of Planar Partitions
GNU General Public License v3.0
57 stars 22 forks source link

segfault when reading features with no geometry #41

Closed adrien-berchet closed 8 years ago

adrien-berchet commented 8 years ago

Hi, I had an issue when trying to read some shapefiles in which some features have no geometry (feature->GetGeometryRef() returns 0). It raised a segfault in this case. I can't make a pull request but just adding this to line 160 solves this issue: if (!feature->GetGeometryRef()) continue; Regards

hugoledoux commented 8 years ago

thanks. But from which branch is this? And out of curiosity, why can't you make a pull request?

adrien-berchet commented 8 years ago

Ups sorry, I meant line 100, not 160. And I did not say it is in the IOWorker.cpp file of the master branch.

For the pull request I have a permission issue: ERROR: Permission to tudelft3d/pprepair.git denied to adrien-berchet-forcity.

hugoledoux commented 8 years ago

You don't have write permission on our code, that's normal. Create a fork of our code, modify it and the create a pull request https://help.github.com/articles/creating-a-pull-request/

adrien-berchet commented 8 years ago

Indeed, sorry! I opened a PR for that.