search

tudelft3d / pprepair

Validation and Automatic Repair of Planar Partitions
GNU General Public License v3.0
57 stars 22 forks source link

Specifying SHP-file output doesn't work as advertised #46

Open emacgillavry opened 7 years ago

emacgillavry commented 7 years ago

According to https://github.com/tudelft3d/pprepair/blob/master/README.md#L31, one should specify cmake -DDRIVER="ESRI Shapefile" . , but on https://github.com/tudelft3d/pprepair/blob/284aba6b5208445dd43899b47a7f62b8db8573cd/CMakeLists.txt#L82, this is option is commented out. Hence, the command pprepair only outputs GeoJSON instead of SHP-file.

bmmeijers commented 7 years ago

I looked a bit into this. I think it does not work to pass the -DDRIVER definition on the command line to cmake. What works for me is modifying the CMakeLists.txt file and uncommenting the desired the driver, while commenting the other.

I would do a out of source build, so then the steps are (when inside the root of the project, and after editing the CMakeLists.txt file):

$ mkdir build $ cd build $ cmake .. $ make