search

tudelft3d / val3dity

Validation of 3D primitives according to the international standard ISO19107
GNU General Public License v3.0
92 stars 23 forks source link

CityJSON with duplicate outer shells reports valid #86

Closed balazsdukai closed 6 years ago

balazsdukai commented 6 years ago

Test pytest -k "402_outer" -v contains two cityjson files. 402_out.json has a MultiSolid with two identical Solids. 402_out_1.json has two identical Solids. Both reports valid, but I think they should report 402.

hugoledoux commented 6 years ago

no they shouldn't. 402 for for duplicated shells in one Solid.

A MultiSolid is a collection of Solids, but the topological relationships between them are not prescribed at all, they can be duplicated. It's just a list of Solids.

Second case: 2 different City Objects having different IDs can have the same geometry as far as val3dity is concerned. Is it "valid"? Perhaps not, but not in val3dity scope at this point... perhaps in the future though.