tudo-aqua / bgw

BoardGameWork
https://tudo-aqua.github.io/bgw/
Apache License 2.0
24 stars 16 forks source link

Set Z layer of ViewComponent within scene without re-adding it to the parent container #362

Closed FrankPabodie closed 1 year ago

FrankPabodie commented 1 year ago

closes #326

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.19 :warning:

Comparison is base (5e57862) 14.77% compared to head (7bace7a) 14.58%.

:exclamation: Current head 7bace7a differs from pull request most recent head 3ad7e75. Consider uploading reports for the commit 3ad7e75 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #362 +/- ## ========================================== - Coverage 14.77% 14.58% -0.19% ========================================== Files 279 274 -5 Lines 7318 7138 -180 Branches 990 960 -30 ========================================== - Hits 1081 1041 -40 + Misses 6155 6032 -123 + Partials 82 65 -17 ``` | [Impacted Files](https://app.codecov.io/gh/tudo-aqua/bgw/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua) | Coverage Δ | | |---|---|---| | [.../kotlin/tools/aqua/bgw/components/RootComponent.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvY29tcG9uZW50cy9Sb290Q29tcG9uZW50Lmt0) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | [...bgw/components/container/GameComponentContainer.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvY29tcG9uZW50cy9jb250YWluZXIvR2FtZUNvbXBvbmVudENvbnRhaW5lci5rdA==) | `53.44% <0.00%> (-8.56%)` | :arrow_down: | | [.../kotlin/tools/aqua/bgw/components/ComponentView.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvY29tcG9uZW50cy9Db21wb25lbnRWaWV3Lmt0) | `16.37% <7.69%> (-1.10%)` | :arrow_down: | | [...tlin/tools/aqua/bgw/components/layoutviews/Pane.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvY29tcG9uZW50cy9sYXlvdXR2aWV3cy9QYW5lLmt0) | `42.37% <75.00%> (+42.37%)` | :arrow_up: | | [.../tools/aqua/bgw/observable/lists/ObservableList.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvb2JzZXJ2YWJsZS9saXN0cy9PYnNlcnZhYmxlTGlzdC5rdA==) | `100.00% <100.00%> (ø)` | | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/tudo-aqua/bgw/pull/362/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

abouzerda commented 1 year ago

Test setZIndex with toFront and toBack together. Maybe toFront should only set it to the front of components with same zIndex

abouzerda commented 1 year ago

Test are failing. StackOverflow. maybe a recursion problem. @FrankPabodie