tudo-aqua / bgw

BoardGameWork
https://tudo-aqua.github.io/bgw/
Apache License 2.0
24 stars 16 forks source link

Fixed a bug where Onkeypressed in scene was not working #368

Closed FrankPabodie closed 1 year ago

FrankPabodie commented 1 year ago

closes #366

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (c6ce44e) 14.28% compared to head (0558603) 14.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #368 +/- ## ========================================== - Coverage 14.28% 14.26% -0.03% ========================================== Files 274 274 Lines 7098 7109 +11 Branches 948 955 +7 ========================================== Hits 1014 1014 - Misses 6025 6036 +11 Partials 59 59 ``` | [Impacted Files](https://app.codecov.io/gh/tudo-aqua/bgw/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua) | Coverage Δ | | |---|---|---| | [...src/main/kotlin/tools/aqua/bgw/builder/Frontend.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvYnVpbGRlci9Gcm9udGVuZC5rdA==) | `0.00% <0.00%> (ø)` | | | [...main/kotlin/tools/aqua/bgw/builder/SceneBuilder.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvYnVpbGRlci9TY2VuZUJ1aWxkZXIua3Q=) | `0.00% <0.00%> (ø)` | | | [.../kotlin/tools/aqua/bgw/components/ComponentView.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvY29tcG9uZW50cy9Db21wb25lbnRWaWV3Lmt0) | `17.47% <ø> (ø)` | | | [...w-gui/src/main/kotlin/tools/aqua/bgw/core/Scene.kt](https://app.codecov.io/gh/tudo-aqua/bgw/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tudo-aqua#diff-Ymd3LWd1aS9zcmMvbWFpbi9rb3RsaW4vdG9vbHMvYXF1YS9iZ3cvY29yZS9TY2VuZS5rdA==) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

abouzerda commented 1 year ago

Does the onKeyPressed EventHandler get triggered both for scene and a child component in the scene?