tudo-r / BatchExperiments

BatchExperiments: Statistical experiments on batch computing clusters
Other
17 stars 5 forks source link

findExperiments arguments #6

Open berndbischl opened 10 years ago

berndbischl commented 10 years ago

There is a problem when one want to program on stuff like prob.pars.

Imagine you want to create such an expression by programming.

Here is a diff that might fix this

--- a/R/findExperiments.R
+++ b/R/findExperiments.R
@@ -48,15 +48,14 @@ findExperiments = function(reg, ids, prob.pattern, prob.pars
     return(ids)

   jobs = getJobs(reg, ids, check.ids = FALSE)
-
   if (!missing(prob.pars)) {
     ind = vapply(jobs, function(job, pars, ee) eval(pars, job$prob.pars, ee),
-                 logical(1L), pars = substitute(prob.pars), ee = parent.frame()
+                 logical(1L), pars = prob.pars, ee = parent.frame())
     jobs = jobs[!is.na(ind) & ind]
   }
   if (!missing(algo.pars)) {
     ind = vapply(jobs, function(job, pars, ee) eval(pars, job$algo.pars, ee),
-                 logical(1L), pars = substitute(algo.pars), ee = parent.frame()
+                 logical(1L), pars = algo.pars, ee = parent.frame())
     jobs = jobs[!is.na(ind) & ind]
   }
   return(extractSubList(jobs, "id", element.value = integer(1L)))

If we touch this we need to properly test different cases.