search

tudorconstantin / Mojolicious-Boilerplate

The Web in an **Awesome** Box
http://boilerplate-tudorconstantin.dotcloud.com/
96 stars 30 forks source link

Menu doesn't currently render #7

Closed colebrumley closed 9 years ago

colebrumley commented 9 years ago

I installed this on a vanilla Mojo installation and the menu didn't render (after I commented out the secret, which is a show stopper), I don't see after_static_dispatch listed as a valid hook in the docs right now so I changed it to before_render.

tudorconstantin commented 9 years ago

thank you for your pull request - I accepted it (without actually checking it). Unfortunately I didn't had any time to update the project lately so its quite up to date. A few things that I'd update are:

So, if you feel like learning mojolicious - you could do that. Also, please provide me with your online profile that I can link to from the contributors sections. Now I added a link to your github profile

On Thu, Oct 9, 2014 at 7:02 AM, elcolio notifications@github.com wrote:

I installed this on a vanilla Mojo installation and the menu didn't render (after I commented out the secret, which is a show stopper), I don't see after_static_dispatch listed as a valid hook in the docs right now so I

changed it to before_render.

You can merge this Pull Request by running

git pull https://github.com/elcolio/Mojolicious-Boilerplate master

Or view, comment on, or merge it at:

https://github.com/tudorconstantin/Mojolicious-Boilerplate/pull/7 Commit Summary

  • Change hook to before_render
  • Commenting out the secret

File Changes

Patch Links:

- https://github.com/tudorconstantin/Mojolicious-Boilerplate/pull/7.patch

https://github.com/tudorconstantin/Mojolicious-Boilerplate/pull/7.diff

— Reply to this email directly or view it on GitHub https://github.com/tudorconstantin/Mojolicious-Boilerplate/pull/7.

Perl developer - powered by www.evozon.com Creator of EatFab http://www.eatfab.com and PRForge http://www.prforge.com Neither the footer nor anything else in this E-mail is intended to or constitutes an electronic signature and/or legally binding agreement in the absence of an express statement of me http://programming.tudorconstantin.com http://www.linkedin.com/in/tudorconstantin http://stackoverflow.com/users/459233/tudor-constantin https://github.com/tudorconstantin

colebrumley commented 9 years ago

Hey no worries, I know how it goes trying to find time for everything. I'm a little internet antisocial, so I don't have many other profiles you could link to, GitHub is probably the best :).

I have been playing around with Mojolicious a little recently and I really like this boilerplate - if I find the minutes I'll keep updating it as I go. One of my changes was upping to Bootstrap 3.2, but I'll take a look at the YAML config and menu next time I'm working on it.