tudorelu / pyjuque

⚡ Open Source Algorithmic Trading Bot for Python.
MIT License
456 stars 90 forks source link

Use FigureWidget #24

Closed revmischa closed 2 years ago

revmischa commented 2 years ago

So it can render inline in jupyterlab

tudorelu commented 2 years ago

Hey there, thanks for the contribution! Sorry for the delayed response.

Can you confirm that changing from Figure to FigureWidget won't change some of the previous functionality? If you're unsure you can make it as a flag that is passed to the PlotData function, either use_figure_widget or jupyter_support which is False by default (it uses Figure if False, FigureWidget if True)

All the other changes look good!