tudorelu / pyjuque

⚡ Open Source Algorithmic Trading Bot for Python.
MIT License
456 stars 90 forks source link

Faulty creation of client_id #26

Open pyjoku opened 2 years ago

pyjoku commented 2 years ago

Describe the bug A clear and concise description of what the bug is. I have bee using pyjuque in test mode and also in live mode. I see the bot getting a signal and trying to place the order. While doing so I get like the same kind of error on both of my exchanges. I use bitpanda and kraken. for Bitpanda the error is {"error":"INVALID_CLIENT_UUID"}

for Kranken I get this <class 'ccxt.base.errors.ExchangeError'> kraken {"error":["EGeneral:Invalid arguments:userref"]}

I am new to python programming so I am not quite sure. I was going through the code and I always get to a point where the custom_order_id is being involved.

Expected behavior calling ccxt.createorder directly leads to an order being palced on the exchange without error.

Desktop (please complete the following information):

In the code I saw that for the uuid4 the dashes were replaced/removed. So maybe thats the reason for the uuid being faulty.

Thanks Jochen

tudorelu commented 2 years ago

Hey there, thanks for giving pyjuque a try!

I have not personally tested pyjuque with bitpanda, but I am working on the kraken integration. For kraken the issue is that it only accepts custom_order_ids formatted as integers. I will push a fix in the next few days.