search

tudorilisoi / ep_fullscreen

A fullscreen plugin for etherpad's ace editor, when in embedded/iframe mode
MIT License
0 stars 1 forks source link

Fullscreen mode breaks history function #1

Closed joergludwig closed 4 years ago

joergludwig commented 9 years ago

Hi,

first of all thank you for your great plugin!

We noticed, that the history function of etherpad does not work in fullscreen mode correctly:

  1. The background color of the history text is not set, so you can see the underlying web site.
  2. You cannot disable fullscreen mode after leaving the history.
tudorilisoi commented 9 years ago

You need to style the history div with CSS, and there may be a javascript error I'm not using history, nor do I have the needed time to handle this problem. Sorry.

joergludwig commented 9 years ago

Solution:

1. Add the following line to src/static/css/timeslider.css:

padmain { background-color: white; }

2. When exiting the history function etherpad reinitializes ep_fullscreen and all variables get lost. I modified index.js to use css classes to switch to fullscreen mode. That way we do not need any internal state anymore. Patch is attached. index.js.txt