search

tudou527 / marketch

Marketch is a Sketch 3 plug-in for automatically generating html page that can measure and get CSS styles on it.
http://tudou527.github.io/marketch/
GNU General Public License v3.0
2.92k stars 302 forks source link

Export not working with Sketch 52.x #180

Closed ggolcher closed 6 years ago

ggolcher commented 6 years ago

Sketch version: 52 (all versions)

I click on export, and it starts but never produces the output files. It still works great in version 51.x, but 52.x is broken.

craigleadspark commented 6 years ago

I am currently experiencing the same issue on 52.1. Please could someone let me know if there is a work around for this.

Unfortunately downloading a previous version of Sketch doesn't pull in the design file correctly, so not an option this time.

MForever78 commented 6 years ago

This is caused by Sketch API change. Marketch used to rely on layer.style().sharedStyleID() to get the shared style (that's the shape or text in the right panel).

I may consider removing this temporarily to workaround the issue.

MForever78 commented 6 years ago

fixed in 49ebd0c9 .

Please help verify and let me know if there's still issues.

ggolcher commented 6 years ago

The Marketch version checker says a new version is available, but Sketchpacks does not offer it to me

MForever78 commented 6 years ago

I'm not sure how Sketchpacks works. Can you install the new version here? Download the zip, uncompress and double click marketch.sketchplugin

https://github.com/tudou527/marketch/releases

ggolcher commented 6 years ago

It's working! I can now use Sketch 52 for my work. Thank you very much! :D

MForever78 commented 6 years ago

Cool. Thanks for verifying.

Closing.