tudou527 / marketch

Marketch is a Sketch 3 plug-in for automatically generating html page that can measure and get CSS styles on it.
http://tudou527.github.io/marketch/
GNU General Public License v3.0
2.92k stars 302 forks source link

No export with slices on artboard #67

Closed giuseppebergman closed 8 years ago

giuseppebergman commented 8 years ago

Export zip files does not complete (no file generated) if one of the selected artboards contains slices. I moved the slice layers outside my artboard "folder" (without moving them inside the viewport), and it worked back.

Here's the error log:

12/01/2016 14:40:19,883 Sketch[1415]: Info: {
    column = 41;
    line = 342;
    sourceURL = "/Users/Me/Library/Application Support/com.bohemiancoding.sketch3/Plugins/marketch-master/marketch.sketchplugin/Contents/Sketch/zip.cocoascript";
}

12/01/2016 14:40:19,883 Export as zipFile (Sketch Plugin)[1415]: TypeError: undefined is not a function (evaluating 'layer.style()')
line: 342
sourceURL: /Users/Me/Library/Application Support/com.bohemiancoding.sketch3/Plugins/marketch-master/marketch.sketchplugin/Contents/Sketch/zip.cocoascript
column: 41

Great plugin otherwise. Thank you for you work!

giuseppebergman commented 8 years ago

Fatih, are you talking about the slices related issue?

fatihturan commented 8 years ago

Ah, I assumed you have experiencing same issue with me. Sorry about it. :)

Latest Marketch plugin did not work for me and reverted to old commit. So I though it would helpful for you but it doesn't related to your issue. Forget it.

giuseppebergman commented 8 years ago

Tudou527, thanks for the quick commit, but I don't get what changed in commit https://github.com/tudou527/marketch/commit/7293058473611a3fd6d5e9031ce424d947e0fb0b: deleted a bracket and added the same? Anyway, https://github.com/tudou527/marketch/commit/7293058473611a3fd6d5e9031ce424d947e0fb0b doesn't change anything to the "slice preventing export" problem.

tudou527 commented 8 years ago

orrect commit is https://github.com/tudou527/marketch/commit/b552518b967b719a3fce4717c755bbd583c7113b

othes is for testing close issues by commit :)

giuseppebergman commented 8 years ago

Ok, the slice issue is fixed indeed with https://github.com/tudou527/marketch/commit/b552518b967b719a3fce4717c755bbd583c7113b . Thanks a lot!

gajenrp commented 8 years ago

Hi,

Marketch plugin is not working for sketch 41 version...please give me solution..