search

tudurom / windowchef

Window Chef is a stacking window manager that cooks windows with orders from the Waitron
https://tudorr.ro/software/windowchef/
ISC License
204 stars 14 forks source link

Added focus last window on window destroy and unmap #29

Closed allora closed 7 years ago

allora commented 7 years ago

Hey, noticed you guys talking about focusing the last window on unmap or destroy. So here you go :D

tudurom commented 7 years ago

Thank you for taking care of focused windows ;)

There is a tiny problem though, some parts of your code are indented with spaces. Windowchef's code is indented with tabs, aligned with spaces. (I really should write a contributor guide).

To fix it, assuming that you use vim, you can use this super retab function from vim wiki.

Thank you very much, as always.

allora commented 7 years ago

Just a question or two. First, is there a particular size for the tab you are expecting (mine is set to 4)? Second, retabing the file affects more than my changes, if you're ok with those changes I can push the commit to my fork.

tudurom commented 7 years ago

  1. I have my tab size set to four, although there is no tab length expected. Because the code is indented with tabs and aligned with spaces, it will look good with any tab size.

  2. Yeah push it.

tudurom commented 7 years ago

Oh, christ. Cancel the retab commit and let me do the retab. It looks like all 4-space sequences were converted to tabs.

allora commented 7 years ago

Sorry about that, should be reverted.

tudurom commented 7 years ago

(^_^)b