search

tudurom / windowchef

Window Chef is a stacking window manager that cooks windows with orders from the Waitron
https://tudorr.ro/software/windowchef/
ISC License
203 stars 14 forks source link

enable_last_window_focusing true and group_toggle #70

Closed neyuki closed 3 years ago

neyuki commented 3 years ago

Hello, if i have enable_last_window_focusing on and have a window in group X then that window opens a dialog window in same group X. After that (2 windows in group X with focused second one) I do group_toggle. Only second one window that was focused is removed. Main one still there.

Is that a normal behavior?

tudurom commented 3 years ago

Which one disappeared, the main window or the dialog?

On 7 January 2021 00:06:31 EET, neyuki notifications@github.com wrote:

Hello, if i have enable_last_window_focusing on and have a window in group X then that window opens a dialog window in same group X. After that (2 windows in group X with focused second one) I do group_toggle. Only second one window that was focused is removed. Main one still there.

Is that a normal behavior?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tudurom/windowchef/issues/70

neyuki commented 3 years ago

second one, the dialog, that was focused. main one is still there. but it is a group toggle, why them both doesn't get lost?

tudurom commented 3 years ago

Windowchef does not add dialog windows to the group of the parent automatically. I think that can be accomplished by respecting the ICCCM WM_TRANSIENT_FOR property. However, there is currently no such functionality.

neyuki commented 3 years ago

ok it doesn't. but you can do it. with ruler or just manual, after dialog win is appear.

tudurom commented 3 years ago

i am going to close the issue, it is normal behaviour.

If you want to submit a PR to automatically add dialogs to the group based on WM_TRANSIENT_FOR, I will accept it.

neyuki commented 3 years ago

How it's work right now:

if enable_last_window_focusing is 0, any windows in group despite their type is removed by group toggle. if enable_last_window_focusing is 1, after dialog window appear and focused group toggle will remove only it, but main window will still be there (tested on firefox and it "save as" dialog).

Can u explain me a logic, isn't a group is superior in hierarchy? If i have some windows in group irrelevant their type, relationship with each other, anything else, group toggle must shut all of them.

I have a "ruler" what says what kind of windows belong to group. I have a group toggle.

tudurom commented 3 years ago

Can you try the issue_68 branch?

tudurom commented 3 years ago

if enable_last_window_focusing is 0, any windows in group despite their type is removed by group toggle. if enable_last_window_focusing is 1, after dialog window appear and focused group toggle will remove only it, but main window will still be there (tested on firefox and it "save as" dialog).

Can u explain me a logic, isn't a group is superior in hierarchy? If i have some windows in group irrelevant their type, relationship with each other, anything else, group toggle must shut all of them.

I think I get it, are you reporting the exact problem as #68?

neyuki commented 3 years ago

just checked issue_68 branch, no, it doesn't solve that question for me.

still, if enable_last_window_focusing is true, dialog window dissapear but main one is still there for group toggle.

may be it is because: group toggle remove all group windows, but last window is focused again and show up?