search

tue-mps-edu / asd-engd-project-2019-thermal-object-detection

This is the repository for the ASD PDEng module 2 project (2020) for AIIM
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

[PR]-Issue#33-Windows installation instructions #34

Closed gccq closed 4 years ago

gccq commented 4 years ago

For the first change

1)The git clone link was corrected to reflect the thermal object detection repo 2) Added git installation link to the prerequisites

No other changes related to windows installation have been made yet. Thus this branch will be merged only when the instructions have been updated which will be done separately.

closes #33

gccq commented 4 years ago

The version 1 of the file is now working. However, it currently requires users to select path for anaconda as well as installation directory twice during the installation. Since this script is nice to have in the first place, the issue will be kept as open until the aforementioned issue is fixed.

gccq commented 4 years ago

Windows installation instructions are now updated in the readme file. Also, the batch file required to carry out the instructions is attached. A good idea would be to follow the instructions and try the installations on your machine. After your review, we can merge this branch and close the issue!

gccq commented 4 years ago

After merging the branch into the master following items need to be changed: 1) Links added in the readme.md documentation 2) git clone link in the installation script

gccq commented 4 years ago

While most of the feedback is incorporated in the pull request following things will remain: 1)To incorporate downloading protoc on the spot has several issues: i) It's a known issue that a lot of installation links for windows tend to disappear or moved around over time. There is no central package location which can be trusted for the version of protoc that we require. Also, its a lot of additional work to integrate this into the final script. Since we have limited time left for this project and this issue has a lower priority than other issues, I propose to keep the folder included as part of the main download. ii) The Linux installation still needs to be tested.

gccq commented 4 years ago

To update on the earlier comment, the I have tested the installation on linux with the new base repo on 1.12 and it works without any issues.

As a result, only issue pending now is of protoc which will not be addressed for the reasons mentioned earlier. Please review the changes!