search

tue-robotics / ed_navigation

ED interface to the base navigation modules
2 stars 4 forks source link

remove timer from depth_sensor_integration #11

Closed MatthijsBurgh closed 5 years ago

alberth commented 5 years ago

Removing a timer that measures but nothing is done with the result is fine imho. Less sure about removing the Timer class itself, sure you never ever want to measure something again?

BTW, ed_navigation looks like a horribly wrong place for such functionality.

MatthijsBurgh commented 5 years ago

The timer is already part of code_profiler. I did a quick check, and I think they are the same. So It is a good thing to remove it here. If you want to use it. We should depend on code_profiler.

MatthijsBurgh commented 5 years ago

And indeed the depth_sensor_integration shouldn't be in ed_navigation.