search

tue-robotics / hero-display

Display sink for the hero display that presents information to the user
0 stars 0 forks source link

Automatically reconnect #2

Closed LoyVanBeek closed 4 years ago

LoyVanBeek commented 5 years ago

https://github.com/tue-robotics/hero_bringup/pull/26 adds a systemd-service to start the display on boot. However, if you start a new instance of hero-start, the display keeps running but does not reconnect to the new rosbridge-websocket.

Some logging which it is connected to and that it's reconnecting etc would be very very handy.

LoyVanBeek commented 5 years ago

@MatthijsBurgh mentioned that e had some code for the auto-reconnecting stuff, but I have no idea how hard this is to do.

reinzor commented 5 years ago

It is using the same class as the dashboard. I will look into this why it is not working

On Tue, 11 Jun 2019, 21:17 Loy, notifications@github.com wrote:

@MatthijsBurgh https://github.com/MatthijsBurgh mentioned that e had some code for the auto-reconnecting stuff, but I have no idea how hard this is to do.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/tue-robotics/hero-display/issues/2?email_source=notifications&email_token=AA73RF3G3GEX2J7NLJJLPTDPZ723NA5CNFSM4HXCR532YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXOGS6Y#issuecomment-500984187, or mute the thread https://github.com/notifications/unsubscribe-auth/AA73RF4II3HI5BK7BWO3KVDPZ723NANCNFSM4HXCR53Q .

reinzor commented 5 years ago

It reconnects but another error popped up: image

MatthijsBurgh commented 5 years ago

Is this error still happening?

reinzor commented 5 years ago

I think so

MatthijsBurgh commented 4 years ago

This is caused by WS@3.3.3 a dependency of roslib. I have asked them to use a new version. I forced roslib to use WS@7.2.1 by hacks right now in v0.1.0