tue-robotics / hero_bringup

bringup for the hero robot
2 stars 2 forks source link

(perception) Extend margin to 20 pixels #124

Open MatthijsBurgh opened 1 year ago

MatthijsBurgh commented 1 year ago

Merge after https://github.com/tue-robotics/ed_perception/pull/46

The old behaviour was margin of 5 pixels. This is the default behaviour. Merging this PR changes that. We can also not merge this PR and keep the old behaviour.

PetervDooren commented 1 year ago

This can only be reviewed by testing on the real robot. Next dev evening go sit with two people and compare the behaviour.

MatthijsBurgh commented 8 months ago

@lottemessing do we still want this?

MatthijsBurgh commented 4 months ago

@lottemessing ping?