Closed MatthijsBurgh closed 1 year ago
@PetervDooren Because of https://github.com/tue-robotics/hero_bringup/pull/123#issuecomment-1265182469 I also suggest to increase the number of laser beams from 100 to 150/200.
You also changed the comments. Was this an error in the original implementation?
I don't get your question completely. It has always been the case that NaNs and r>= max_range
are part of the counted particles. Otherwise the selection process becomes really complex.
As discussed with @PetervDooren, merging this one without increasing the number of beams. Need to analyze the performance after merging this one. After which we can increase the number of beams.
Based on motion capture measurements and experimental testing afterwards.