Feature/openpose singleshot

tue-robotics / hero_bringup

bringup for the hero robot

2 stars 2 forks source link

Feature/openpose singleshot #19

Closed LoyVanBeek closed 5 years ago

LoyVanBeek commented 5 years ago

Fixes https://github.com/tue-robotics/tue_robocup/issues/784

LoyVanBeek commented 5 years ago

You are way behind. Because the service has been renamed to hero2-openpose.service. And this is too dirty fix.

~~And where would I find the proper file?~~ This is what rebasing is for. What would be a better way? I prefer to not change the image_recognition code itself. This fixes the issue and documents how.

MatthijsBurgh commented 5 years ago

The openpose node should be able to run both topic and service mode. Maybe it is already in there.

LoyVanBeek commented 5 years ago

The openpose node should be able to run both topic and service mode. Maybe it is already in there.

It is capable of both. I just point the topic to somewhere else so only the service is used.

MatthijsBurgh commented 5 years ago

The openpose node should be able to run both topic and service mode. Maybe it is already in there.

It is capable of both. I just point the topic to somewhere else so only the service is used.

It should be a parameter, don't let it listen to a dead topic.

LoyVanBeek commented 5 years ago

Matthijs, I'm getting quite done with this.

The topic is already a parameter so we can do stuff like this.
do not want to do a new release of image_recognition
we have a tournament in a few weeks
this is 100% self-explanatory in the config of a robot where I think it should be.

ar13pit commented 5 years ago

@MatthijsBurgh My changes in this PR have been agreed upon by both @LoyVanBeek and @reinzor. So this is GTM.

MatthijsBurgh commented 5 years ago

@MatthijsBurgh My changes in this PR have been agreed upon by both @LoyVanBeek and @reinzor. So this is GTM.

If they agree, they should approve. I will do it for now.