search

tue-robotics / tue-env

Package manager that can be used to install (ROS) dependencies
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

feat: AGMAH backport #672

Closed ar13pit closed 1 year ago

ar13pit commented 1 year ago

We need more logging in the new CI code

Can you be a bit more specific about where? There's not much which has been added. It is just a job that is combining multiple manifest files of different architectures :)

MatthijsBurgh commented 1 year ago

We need more logging in the new CI code

Can you be a bit more specific about where? There's not much which has been added. It is just a job that is combining multiple manifest files of different architectures :)

I think we should minimally log everything we write to either GITHUB_ENV or GITHUB_OUTPUT

MatthijsBurgh commented 1 year ago

Also we should fix the cleanup of untagged containers. The problem is that the BRANCH-amd64 manifest, doesn't have any related containers

ar13pit commented 1 year ago

This PR actually removes of the random untagged containers from being created to begin with. All the unknown/unknown ones to be precise.

MatthijsBurgh commented 1 year ago

This PR actually removes of the random untagged containers from being created to begin with. All the unknown/unknown ones to be precise.

That is great improvement. But the old job still pushes the BRANCH-amd64 tag. And the manifest job pushes the BRANCH tag. So we should streamline this worflow.

MatthijsBurgh commented 1 year ago

@ar13pit can you work on the logging? So that at least everything that is written to variables etc are also printed, human-readable please.