search

tuffy / bitstream-io

Library for reading/writing un-aligned values from/to streams in big-endian and little-endian formats
Apache License 2.0
52 stars 20 forks source link

Please specify rust-version #21

Closed kornelski closed 4 months ago

kornelski commented 4 months ago

This crate uses just-released Rust 1.79 feature without specifying rust-version in Cargo.toml. This makes older Rust confuse users complaining about experimental features and barfing compilation errors, instead of clearly communicating that their Rust is too old.

9mm commented 4 months ago

Now this says I have to use 1.79 and can't even use 1.78... is this the expected behavior?

9mm commented 4 months ago

Im new to rust and just included the image crate. I dont believe I use inline consts but... i suppose it doesnt matter because I upgraded rust to 1.79

kornelski commented 4 months ago

Oh, nevermind. I've noticed the problem was only in 2.4.0, and 2.4.1 has rust-version.

EdJoPaTo commented 2 months ago

@tuffy Given that 2.4.0 and 2.4.1 only differ in the rust-version being specified… Can you yank 2.4.0?

The upcoming edition 2024 / resolver=3 allows for fallback versions that work with a lower version. Testing it (https://github.com/rust-lang/cargo/issues/13873) with a bunch of my projects quickly resulted in finding this crate where 2.4.0 is tried to be used which doesn't work better than 2.4.1. And as they are nearly identical, I'd suggest yanking 2.4.0 to reduce this pain point a bit.

PS: I like seeing the usage of more const!