search

tuffy / python-audio-tools

A collection of audio handling programs which work from the command line.
http://audiotools.sourceforge.net
GNU General Public License v2.0
249 stars 58 forks source link

Why is there a #!/usr/bin/python? #45

Open afreof opened 9 years ago

afreof commented 9 years ago

While trying to create a fedora package I recognized that the following files (v2.22) start with #!/usr/bin/python on the first line. Is there something I can't see? I don't think that all of these files should be executed by a user...

py_encoders/wavpack.py wavpack.py init.py py_encoders/flac.py image.py m4a_atoms.py ape.py toc/tokrules.py py_encoders/init.py py_decoders/shn.py mp3.py musicbrainz.py freedb.py vorbiscomment.py id3v1.py text.py py_decoders/init.py toc/yaccrules.py tta.py cue/yaccrules.py ogg.py flac.py opus.py py_decoders/wavpack.py aiff.py py_encoders/shn.py py_encoders/alac.py toc/init.py delta.py cue/tokrules.py py_encoders/tta.py m4a.py vorbis.py py_decoders/alac.py py_decoders/flac.py ui.py player.py id3.py cue/init.py accuraterip.py shn.py dvda.py py_decoders/tta.py wav.py au.py

tuffy commented 9 years ago

Those are just an old artifact of cutting and pasting license text across files. I've now removed the unnecessary "/usr/bin/python" headers from library files that don't need them.

afreof commented 9 years ago

Thank you for the patch! (and of course, for audiotools) There are two more files:

audiotools/__init__.py
audiotools/aiff.py

By the way, I'm trying to get python-audio-tools packaged for fedora...

tuffy commented 9 years ago

Ah, good catch. I've updated those as well.