search

tuffy / python-audio-tools

A collection of audio handling programs which work from the command line.
http://audiotools.sourceforge.net
GNU General Public License v2.0
249 stars 58 forks source link

samplerate/common.h needs patching for FreeBSD #49

Open ghost opened 9 years ago

ghost commented 9 years ago

This needs to include stdint.h for int32_t to be defined. Otherwise the build fails on FreeBSD. It previously used HAVE_STDINT_H which is a macro defined by autotools. You do not use autotools for this software, so I replaced it with a macro check against the version of standard C being used. If the compiler advertises C99 or newer, then stdint.h is present because it is a mandatory header for conforming C99 or newer implementations. Please apply the below patch.

--- src/samplerate/common.h.orig 2014-12-31 18:30:53 UTC +++ src/samplerate/common.h @@ -25,7 +25,7 @@

ifndef COMMON_H_INCLUDED

define COMMON_H_INCLUDED

-#ifdef HAVE_STDINT_H +#if STDC_VERSION >= 199901L

include

elif (SIZEOF_INT == 4)

typedef int int32_t ;

tuffy commented 9 years ago

I've gone ahead and just imported stdint outright. Other places in audiotools import it directly and I believe most relevant C implementations should have it as part of the standard library by now.