tuffy / python-audio-tools

A collection of audio handling programs which work from the command line.
http://audiotools.sourceforge.net
GNU General Public License v2.0
248 stars 57 forks source link

tta CUESHEET support not working #56

Open ghost opened 8 years ago

ghost commented 8 years ago

I have only found one software so far that can produce whole cd rips with TTA. Python audio tools looks for this in the 'Cuesheet' while CUERipper embeds it within the 'CUESHEET' tag. Please fix the tag name. Or is there actually software that embeds it within the tag you are using now?

tuffy commented 8 years ago

The cuesheet tag isn't in the APEv2 or True Audio specifications at all, so it's going to have to be some sort of de-facto standard. But WavPack uses APEv2 like TTA and it explicitly uses "Cuesheet" for the key name in its specification. So it makes sense for two lossless formats using the same tagging format to use a non-standard tag like "Cuesheet" consistently. Does CUERipper also use "CUESHEET" when embedding cuesheets in WavPack files? If so, it may be a CUERipper bug.

"CUESHEET" itself is a strange choice considering how all the other APEv2 tags are capitalized. But I might be able devise an alias for it if necessary.

ghost commented 8 years ago

Yes, it uses "CUESHEET" for both TTA and WV files. It appears to use the name "CUESHEET" for everything. FLAC, TTA, WV, APE, etc. Perhaps you could add a fallback to use "CUESHEET" if "Cuesheet" is not found?

tuffy commented 8 years ago

That sounds good. I've pushed out a fix which treats "CUESHEET" as an alias for "Cuesheet" in APEv2 tags. Hopefully that'll take care of it.