search

tugberkugurlu / AspNetCore.Identity.MongoDB

MongoDB Data Store Adaptor for ASP.NET Core Identity
MIT License
230 stars 69 forks source link

fix namespaces #10

Closed tugberkugurlu closed 8 years ago

tugberkugurlu commented 8 years ago

Some (or all?) namespaces are Dnx.Identity.MongoDB. It should really be AspNetCore.Identity.MongoDB or starts with that.

runxc1 commented 8 years ago

Why not just shorten it to Identity. MongoDB?

On Aug 25, 2016 2:45 PM, "Tugberk Ugurlu" notifications@github.com wrote:

Some (or all?) namespaces are Dnx.Identity.MongoDB. It should really be AspNetCore.Identity.MongoDB or starts with that.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tugberkugurlu/AspNetCore.Identity.MongoDB/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFFaIYLNR8tdSjJS-LaSH2LUHfLr5nMks5qjf7OgaJpZM4JtfA2 .

tugberkugurlu commented 8 years ago

@runxc1 good suggestion, we could do. I honestly don't like .NET namespace convention or the package naming convention 😞 For example, Go has short package names on core lib: https://golang.org/pkg/ which is amazing considering what we have now: System.Threading.Tasks, System.Security.Claims, etc. 😞 However, I felt like honoring the ecosystem's convention is more valuable than going rogue.

I liked Identity.MongoDB though, let's go with that 👍

tugberkugurlu commented 8 years ago

I thought about this and I am leaning towards AspNetCore.Identity.MongoDB even if I don't like it :disappointed: It will be consistent with the ASP.NET Core libraries. Otherwise, it will be confusing as this doesn't support "non-core" Identity.