Closed frmokoena closed 7 years ago
@rm2k there are a few outstanding questions with this PR. Do you want to have a look at them? This is something I want to get it in but with minimum public APIs.
@tugberkugurlu did my comments come through? what's your take on them?
Sorry, it has been a while. While I was busy with other stuff, v2.0.0 has been released and it seems like v1 is not compatible with that. So, move to v2 makes more sense now.
It also seems that using the providers w/o roles is easier now. UserClaimsPrincipalFactory<TUser>
is provided out of the box but AddIdentity<TUser>
is not. Would you like to add something smilar to https://github.com/tugberkugurlu/AspNetCore.Identity.MongoDB/blob/a88391b52fb9dc6c615461b9d53f797461b85c55/samples/IdentitySample.Mvc/MongoIdentityServiceCollectionExtensions.cs and PR that instead?
Also, some extension methods to add the store to the DI system would be nice if you want to PR that as well.
@rm2k I will close this one but let me know about https://github.com/tugberkugurlu/AspNetCore.Identity.MongoDB/pull/34#issuecomment-328307809
@tugberkugurlu Sure. I'll look into your recommendations.
Thanks for this! 🎉