search

tugberkugurlu / AspNetCore.Identity.MongoDB

MongoDB Data Store Adaptor for ASP.NET Core Identity
MIT License
230 stars 69 forks source link

Any chance of a Core 2.0 of this repo? #47

Closed Mech0z closed 7 years ago

Mech0z commented 7 years ago

Just wonder if I should just use this one and upgrade to 2.0 afterwards

tugberkugurlu commented 7 years ago

Hey, I have been think about upgrading to v2 for a while now but not sure what is changed there for store interface. Maybe 1 impl of store should work for v2 as well?

If you want to give it a go, that's totally fine! Just let me know and send a PR afterwards.

We should at least upgrade to .NET SDK 2.0.

Mech0z commented 7 years ago

Can try to look at it, but security aint my forcé, which is why I am looking at packages like this :) but if its mostly upgrade and maybe calling it from a new setup method in startup then it should be fine

vladimir-kucher commented 7 years ago

Hey. I've ported it to .net core 2.0 + visual studio 2017. Can I put a PR?

tugberkugurlu commented 7 years ago

Yes, please do :tada:

vladimir-kucher commented 7 years ago

It seems that patch-version.sh is failing. Since there is no porject.json file exists for .net core 2.0 I am not familiar with build scripts. Can you take a look please?

tugberkugurlu commented 7 years ago

Ah, that's expected. Thanks for letting me know, I will take a look!

tugberkugurlu commented 7 years ago

@vladimir-kucher's amazing work on #48 and after that, doing #50 resolved this issue 🎊

razzeee commented 7 years ago

So will you push this to nuget (as a preview) or what are the steps that will have to happen now?

tugberkugurlu commented 7 years ago

A few things are not working with the sample like https://github.com/tugberkugurlu/AspNetCore.Identity.MongoDB/issues/49. As soon as we have the sample working, I can push a new version to NuGet.

tugberkugurlu commented 7 years ago

@Razzeee let me know if you want to give it a try on making the sample work

razzeee commented 7 years ago

I don't think I have the skillset/time required for that.

tugberkugurlu commented 7 years ago

No worries, I will spend some time to make that work. Will ping you when I am done so that you would have a chance to try it out as well?

razzeee commented 7 years ago

Sure, sounds fine

On Tue, 19 Sep 2017, 11:49 Tugberk Ugurlu notifications@github.com wrote:

No worries, I will spend some time to make that work. Will ping you when I am done so that you would have a chance to try it out as well?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tugberkugurlu/AspNetCore.Identity.MongoDB/issues/47#issuecomment-330488664, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqyZOFsawgCCdL5cC_oiCuMX0U6gRXmks5sj44ngaJpZM4PNcKP .

agc93 commented 7 years ago

Any news on getting this pushed to NuGet? Maybe another prerelease version at least so people can try it out?