Migrating to sdk .net core 2.0 + VisualStudio 2017

vladimir-kucher commented 7 years ago

Seems like build script is failed due to lack of project.json in VS2017 project structure

razzeee commented 7 years ago

Can you check the travis config? This seems fishy to me as you probably want to use dotnetcore 2.0 here? https://github.com/vladimir-kucher/AspNetCore.Identity.MongoDB/blob/Core2Migration/.travis.yml#L21

tugberkugurlu commented 7 years ago

This is amazing @vladimir-kucher and @Razzeee! Thanks for doing this, will have a look now and try to get the build passing!

tugberkugurlu commented 7 years ago

This is mostly positive and lots of good things under this! A few things that worth noting:

Do you know whether ASP.NET Identity 1.1.2 store interface is compatible with 2.0.0? If that's the case, targeting that would be more beneficial. In any case, let's keep this PR focused to SDK move which is an amazing step on its own.
I assume that targeting Identity 2.0.0 package was not your main intention with this PR. Am I correct to assume that?
Build script needed a change the way it builds and created packages. I created https://github.com/tugberkugurlu/AspNetCore.Identity.MongoDB/tree/dotnetcore2-sdk branch on top of this. Let's observe the build of that and if it passed, I pushed my changes to your branch and merge that in! Keep in mind that this will not erase your commits and you will be seen as a contributor 🎉

There are a few other things I have change under dotnetcore2-sdk branch. I will point some of the important ones out as code comments.

tugberkugurlu commented 7 years ago

Had a few issues with running the tests under Travis CI but it all seems to be working now 🎉 once it is green, we can get this in :shipit:

tugberkugurlu commented 7 years ago

It turned out that you cannot target 1.1.2 and work for 2.0.0 of identity. I made the move on https://github.com/tugberkugurlu/AspNetCore.Identity.MongoDB/pull/50

tugberkugurlu / AspNetCore.Identity.MongoDB