search

tugberkugurlu / AspNetCore.Identity.MongoDB

MongoDB Data Store Adaptor for ASP.NET Core Identity
MIT License
229 stars 69 forks source link

Implemented IUserAuthenticatorKeyStore and IUserTwoFactorRecoveryCode #53

Closed tobieheyns closed 5 years ago

tugberkugurlu commented 6 years ago

@tcheyns sorry for jumping in late 😢 and huge thanks for this!

Build seems to be failing on Travis CI, any thoughts on why?

tobieheyns commented 6 years ago

Hi

I am not sure why its failing. Its compiling on my side, but let me do some investigation.

tobieheyns commented 6 years ago

Travis is failing on the tests implementation. When I run the tests on my machine, its trying to access the localhost instance of MongoDB.

**_"AspNetCore.Identity.MongoDB.Tests.dll" -nocolor -verbose -internaldiagnostics Discovering: AspNetCore.Identity.MongoDB.Tests Discovered: AspNetCore.Identity.MongoDB.Tests Starting: AspNetCore.Identity.MongoDB.Tests AspNetCore.Identity.MongoDB.Tests.MongoIdentityUserTests.MongoIdentityUser_CanBeSavedAndRetrieved_WhenItBecomesTheSubclass AspNetCore.Identity.MongoDB.Tests.MongoUserStoreTests.MongoUserStoreShouldPutThingsIntoUsersCollectionByDefault No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

tugberkugurlu commented 6 years ago

@dealproc we can get this going once we fix https://github.com/tugberkugurlu/AspNetCore.Identity.MongoDB/issues/55

dealproc commented 6 years ago

Maybe we need to think about setting up the build pipeline to execute with docker containers, if that is indeed possible?

dealproc commented 6 years ago

@tcheyns Can you implement the Token Storage (#45) into this pull request as well and provide tests? According to me trying to do this, the interface includes three methods to be implemented, which you seem to have already (SetTokenAsync, RemoveTokenAsync, and GetTokenAsync). This would complete the remainder of the work and we can close this PR as well as #45.

dealproc commented 5 years ago

@tcheyns I am going to consider that this PR is no longer valid as-is, and I am going to extract the work that you have done, along with the requests I made so we can get the functionality that #45 can be closed, and we can keep the functionality you've built with this PR. I apologise for the delay in getting back to this, but other projects had to take priority.

dealproc commented 5 years ago

And I apologise.. I didn't thoroughly review the changes. It seems as if these changes were indeed in-place.