search

tugberkugurlu / gulp-dnx

Gulp plugin for ASP.NET 5
MIT License
38 stars 14 forks source link

renaming k to dnx #10

Closed luisrudge closed 9 years ago

luisrudge commented 9 years ago

fix #9

luisrudge commented 9 years ago

Maybe we should rename to gulp-dnx? Not sure the aspnet work will last for long

tugberkugurlu commented 9 years ago

Yes, correct. Good thought. It can be dnx only but we also have some web specific stuff like calling web command by default.

If we can remove those conventions, why not. What do u think?

luisrudge commented 9 years ago

I already removed the web command. no the dnxCommand is required and there's no defaults

tugberkugurlu commented 9 years ago

Ah, cool! Yes, gulp-dnx seems better than. Do you want to update it accordingly?

luisrudge commented 9 years ago

Yep. We'll do it today

tugberkugurlu commented 9 years ago

:+1:

luisrudge commented 9 years ago

@tugberkugurlu Let me know when you review this. I changed the dnxCommand to be the first parameter of the function. It's all in the readme.

luisrudge commented 9 years ago

any news? :)

tugberkugurlu commented 9 years ago

Damn, busy days :s on my phone now but will look at it and merge it in about two hours :smile: sorry for the delay :s

luisrudge commented 9 years ago

no problem. I want to fix the other problem too but I need this merged: https://github.com/npm/npm/issues/8359#issuecomment-106572853