search

tugberkugurlu / k-http

ASP.NET 5 Command-line HTTP server to host static files
MIT License
15 stars 3 forks source link

support for mac and linux #15

Closed tugberkugurlu closed 9 years ago

tugberkugurlu commented 9 years ago

Fixes #4 :fireworks: :boom: :dancers: :dancer:

It happily runs on Linux and I will just assume that it runs on Mac as well. It just looks and see what the OS is and if it's not windows, it runs on Kestrel. There are some weird stuff like stopping the server gives an exception on dispose, kestrel doesn't log the host and port but minor stuff. Added some logging on the console to indicate start and shut down, it should help:

image

image

luisrudge commented 9 years ago

@tugberkugurlu why not use kestrel in windows too?

tugberkugurlu commented 9 years ago

@luisrudge WebListener is more stable and mature than kestrel AFAIK. However, it shouldn't matter for this project that much as it's dev-only but kestrel seems a bit clunky to me (not being able to dispose, etc.). More info: https://vimeo.com/131631887

OTOH, as a user, it should be transparent to you. Any specific reason you want kestrel in windows, too?

luisrudge commented 9 years ago

nope. Just less code to maintain :D

luisrudge commented 9 years ago

Well. scratch that. you don't have to maintain nothing, just an if/else :D I forgive you haha :)

tugberkugurlu commented 9 years ago

:smile: